search

flintlib / flint

FLINT (Fast Library for Number Theory)
http://www.flintlib.org
GNU Lesser General Public License v3.0
444 stars 245 forks source link

Clean up and document fft_small #1356

Open fredrik-johansson opened 1 year ago

fredrik-johansson commented 1 year ago

I've added basic documentation for machine_vectors.h. It's not clear what the assumptions are for some of the functions doing modular arithmetic.

albinahlback commented 11 months ago

For example, what are the criteria for the initial prime p used in mpn_ctx_init? Seems like a necessary condition is $p > 2^{14}$. The first prime I can find here that works is 16567, but the following prime 16573 does not work.

fredrik-johansson commented 7 months ago

I should try to get into the habit of adding some comments whenever I figure out what some piece of fft_small does.

I added some explanations for the parameters in mpn_ctx_mpn_mul in 6879047.