flintlib / flint

FLINT (Fast Library for Number Theory)
http://www.flintlib.org
GNU Lesser General Public License v3.0
403 stars 235 forks source link

Introduce `ca_types.h`, `gr_types.h` and `nf_types.h` #1962

Closed albinahlback closed 1 month ago

albinahlback commented 1 month ago

Perhaps these headers should be split in some other ways. For instance, I pushed qqbar_t into ca_types.h, which perhaps is not the most fitting.

A multithreaded build now takes around 2% less time to build than before.

Will squash when it seems to be okay.

fredrik-johansson commented 1 month ago

Looks generally OK, but not sure about moving the qqbar and fexpr types which are really independent of the ca types.

fredrik-johansson commented 1 month ago

Also, nf_elem.h and nf.h aren't big files, nor widely included in other files. We could just as well keep the types there and de-inline the remaining inline functions in nf_elem.h to save on some bloat, I think.

albinahlback commented 1 month ago

Yeah, I agree. Perhaps group together the algebraic number theory stuff in some nice way, namely nf, qfb and qqbar?

albinahlback commented 1 month ago

Superseded by #1987