Closed albinahlback closed 1 month ago
Looks generally OK, but not sure about moving the qqbar
and fexpr
types which are really independent of the ca
types.
Also, nf_elem.h
and nf.h
aren't big files, nor widely included in other files. We could just as well keep the types there and de-inline the remaining inline functions in nf_elem.h
to save on some bloat, I think.
Yeah, I agree. Perhaps group together the algebraic number theory stuff in some nice way, namely nf, qfb and qqbar?
Superseded by #1987
Perhaps these headers should be split in some other ways. For instance, I pushed
qqbar_t
intoca_types.h
, which perhaps is not the most fitting.WARN_UNUSED_RESULT
toFLINT_WARN_UNUSED
.A multithreaded build now takes around 2% less time to build than before.
Will squash when it seems to be okay.