search

flintlib / python-flint

Python bindings for Flint and Arb
MIT License
131 stars 25 forks source link

first sketch of cython-lint workflow #204

Closed fchapoton closed 1 month ago

fchapoton commented 1 month ago

let's try to add a cython-lint checker in a workflow

oscarbenjamin commented 1 month ago

It might be that the workflow doesn't run until it is actually merged or something.

fchapoton commented 1 month ago

yes, could be. I have to add many ignored codes too

fchapoton commented 1 month ago

now with large-scale removal of unused variables and imports. The former in particular may benefit from a careful check.

oscarbenjamin commented 1 month ago

I've been through all the diff and it looks good although I'll let the CI finish.

fchapoton commented 1 month ago

I have rebased the branch on master, squashed the first few commits and shortened the ignore list

oscarbenjamin commented 1 month ago

Okay, looks good to me. I'll wait for CI to finish.

oscarbenjamin commented 1 month ago

I'm going to add a development workflow page to the docs and I'll mention how to run cython-lint there. We should probably arrange it so that you can do e.g.

$ spin lint

since spin is the developer frontend.

oscarbenjamin commented 1 month ago

Okay this looks good. Thanks!