search

flintlib / python-flint

Python bindings for Flint and Arb
MIT License
132 stars 27 forks source link

rename l_function method name #212

Closed GiacomoPope closed 2 months ago

GiacomoPope commented 2 months ago

Fixes #210

oscarbenjamin commented 2 months ago

I'm not sure it is worth changing the name here. I don't know much about this function and I don't know what it would normally be called. If the linter wasn't complaining then it would not have been suggested to change this so I would probably just leave it I think.

Putting "function" in the name seems sort of redundant when most methods are functions.

GiacomoPope commented 2 months ago

I think l_function makes sense, as it's a mathematical object known as a l-function (https://en.wikipedia.org/wiki/Dirichlet_L-function), obviously all the code is built with methods/functions but just calling it l doesnt seem very helpful to me. Happy to just close this though if you disagree

oscarbenjamin commented 2 months ago

Okay, let's get it in.