flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS
https://saml-sp.flipboxfactory.com/
Other
19 stars 5 forks source link

Saml2Container compatibility errors #110

Closed masonry47 closed 3 years ago

masonry47 commented 3 years ago

Hi there!

We are having issues with Azure configuration. We followed the recent youtube video which I believe showed a newer way for setup on the Azure side.

The error is happens when clicking the "login with azure" button, so it is before any actual user info is being passed back and forth. It just throws the internal server error, which logs the following

2021-04-19 11:59:20 [-][-][fb781rckeip4lu79vmono1ko19][error][yii\base\ErrorException:64] yii\base\ErrorException: Declaration of flipbox\saml\core\containers\Saml2Container::debugMessage($message, $type): void must be compatible with SAML2\Compat\AbstractContainer::debugMessage($message, string $type): void in /home/xxxxxxxxx/public_html/vendor/flipboxfactory/saml-core/src/containers/Saml2Container.php:14
Stack trace:
#0 [internal function]: yii\base\ErrorHandler->handleFatalError()
#1 {main}
2021-04-19 11:59:19 [-][-][fb781rckeip4lu79vmono1ko19][info][application] $_GET = [
    'p' => 'sso/login/request/5bc4c2b2-115d-47cf-a0f9-3caad616e421'
    'RelayState' => 'https://url.com/admin'
]

thanks for any help on this!

dsmrt commented 3 years ago

👋 @masonry47 !

Good catch! I aligned the classes in the parent lib (saml-core) for that class. I believe this should fix the errors you are seeing.

Run a composer update on the saml-core library like so (you may need to edit the composer.json file as well):

composer update flipboxfactory/saml-core

Note: flipboxfactory/saml-sp package may not need to update. I didn't need to patch any changes in that package to fix this issue.

masonry47 commented 3 years ago

that did it. Thanks!

dsmrt commented 3 years ago

Awesome! Let me know if you run into anything else!