flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS
https://saml-sp.flipboxfactory.com/
Other
19 stars 5 forks source link

Settings shouldn't be available on Project Config sites #114

Closed darylknight closed 3 years ago

darylknight commented 3 years ago

I just went to change the Default Entity ID on our staging server and got the standard 'changes can't be made while allowAdminChanges is false' error, on admin/saml-sp/settings

If this is controlled by project config, it should either be hidden in environments where changes aren't allowed, or set to 'read only'

image

dsmrt commented 3 years ago

👋 @darylknight

good call. I’ll take a look

dsmrt commented 3 years ago

Patched the saml-core package that manages this area. Update this plugin package and you should se this fixed.