search

flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS
https://saml-sp.flipboxfactory.com/
Other
19 stars 5 forks source link

Entity ID of SP not used #171

Closed FrankZwiers closed 2 years ago

FrankZwiers commented 2 years ago

We have a setup with multiple IDP's that require different Identity IDs(e.g. different Azure tenants and different Azure applications for different environments). When attempting to authenticate via the /sso/login/request/<IdP provider uid>/<SP provider uid> structure it does not send the Entity ID of the SP but always the default Entity ID.

This could be solved by changing line 91 of src/services/messages/AuthnRequest.php to $serviceProvider->getEntityId()

dsmrt commented 2 years ago

👋 @FrankZwiers ,

Good catch. I think you have this right. I’m going to review and get a patch out.

dsmrt commented 2 years ago

Hi @FrankZwiers,

Great catch and good issue.

Give 2.7.4 a try: https://packagist.org/packages/flipboxfactory/saml-sp#2.7.4

Thanks!

FrankZwiers commented 2 years ago

Works like a charm, thanks for the quick support.