search

flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS
https://saml-sp.flipboxfactory.com/
Other
19 stars 5 forks source link

Formatting issues in the side panels #182

Closed uandco closed 1 year ago

uandco commented 1 year ago

The side panels lack padding:

image image

Looks like a regression with Craft 4

Version info: Craft edition & version | Craft Pro 4.3.4 SAML Service Provider | 4.0.4

dsmrt commented 1 year ago

Updated with new versions in core and sp package. Update using this cli command: composer update flipboxfactory/saml-core flipboxfactory/saml-sp

uandco commented 1 year ago

Hi, thanks for fixing this, but the code seems unnecessary complicated. You're fighting what Craft provides out of the box with inline styles, which are prone to causing issues with Craft upgrades or custom control panel styles.

For example cleaning up the code the "site" block achieves the same without the extra inline styles:

image

(it's still missing a for attribute on the label though). The same kind of markup simplification can be applied to the entityID field (see for example how Craft does it out of the box for the "slug" field in entries)