flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS
https://saml-sp.flipboxfactory.com/
Other
19 stars 5 forks source link

SSO HTTP-Redirect Binding Support #41

Closed dennismeissner closed 4 years ago

dennismeissner commented 4 years ago

Hey, there is a statement in your Code which says:

https://github.com/flipboxfactory/saml-sp/blob/7c15e2af4d79e334a1f0a87139060891897cfca3/src/services/messages/AuthnRequest.php#L33

Is there a plan to fix this soon? Actually at the moment it fails with the following message: Call to a member function getLocation() on null

if i replace Constants::BINDING_HTTP_POST with Constants::BINDING_HTTP_REDIRECT it works for me.

my metadata snapshot:

...
    <md:SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="https://-----/simplesaml/saml2/idp/SingleLogoutService.php"/>
    <md:NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:transient</md:NameIDFormat>
    <md:SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="https://-----/simplesaml/saml2/idp/SSOService.php"/>
dsmrt commented 4 years ago

Done. Find it in version 2.0.13.