flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS
https://saml-sp.flipboxfactory.com/
Other
19 stars 5 forks source link

Issue with with Single Logout Configuration #57

Closed eheiser closed 4 years ago

eheiser commented 4 years ago

We still have a problem with the configuration of the “Craft SAML SSO Service Provider” plugin. It looks like the “Single Logout Service (SLO) Binding” isn’t detected from the metadata: (screenshot1) The Metadata URL we are using is https://auth.vincotte.be/samlp/metadata/mAbNvxaV1H6DeOK5C1at2DGviwAOA2e9

As shown in the screenshot below this metadata does contain a “SingleLogoutService” tag with binding “urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect”. (screenshot2 screenhot1 screenshot2

) If you'd like an admin account to take a look please let me know.

dsmrt commented 4 years ago

Got it! I have a patch up in 2.1.6.

eheiser commented 4 years ago

Awesome - thanks!

Erwin Heiser | Focus! bvba focus-webdesign.be | erwin.heiser@gmail.com

On Tue, 5 May 2020 at 22:28, Damien Smrt notifications@github.com wrote:

Got it! I have a patch up in 2.1.6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flipboxfactory/saml-sp/issues/57#issuecomment-624288384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVHFUF2ZAXG6YGD5EXETLRQBZGTANCNFSM4MZTOKAQ .

eheiser commented 4 years ago

Added the patch but we're still running into the same issue. Check the public url https://auth.vincotte.be/samlp/metadata/mAbNvxaV1H6DeOK5C1at2DGviwAOA2e9

dsmrt commented 4 years ago

What issue are you seeing. Is SLO not working? Do you have an error?

I assumed you were referring to the missing SLO value in that text field.

dsmrt commented 4 years ago

Actually, one thing I didn’t mention is you probably need to update our saml core package as well. composer update flipboxfactory/saml-core.

eheiser commented 4 years ago

Ran the composer command but it says there is "Nothing to install or update"

dsmrt commented 4 years ago

@eheiser, as my commit message suggests, I missed a spot! sorry about that! Try a composer update flipboxfactory/saml-sp. This should update saml-sp and saml-core. Let me know if you have any issues.

eheiser commented 4 years ago

still says "nothing to install or update" - should I run this command in a particular directory?

dsmrt commented 4 years ago

I bet it has something to do with the composer.json constraints on the plugin. Try composer require "flipboxfactory/saml-sp:^2.1" and see if that works for you. If not, try composer clear-cache then try the require or update again.

eheiser commented 4 years ago

that did it, update went through. I have to convene with another dev to continue, will keep you posted of any progess. Thanks already!

dsmrt commented 4 years ago

Let me know how this goes! Closing this for now but feel free to comment here or hit me up on twitter if needed.