Bug in CP links - Githubissues

flipboxfactory / saml-sp

SAML Service Provider (SP) Plugin for Craft CMS

https://saml-sp.flipboxfactory.com/

Other

19 stars 5 forks source link

Bug in CP links #96

Closed bs1180 closed 3 years ago

bs1180 commented 3 years ago

Hey there, I'm using 2.6.1 (with Craft 3.6.4.1) and there seems to be a bug in the links in the CP.

Screenshot 2021-02-10 at 12 21 09

If I click "Staging" in this view, it instead edits the Test IDP - it seems the /admin/saml-sp/metadata/my-provider URL points to the wrong entity. I've worked around it by manually changing the URL to the right ID (eg. admin/saml-sp/metadata/5)

Thanks.

dsmrt commented 3 years ago

I’ll take a look.

dsmrt commented 3 years ago

I'm not seeing the same result on my side so this might be a config difference.

Questions: Are you using multisite (do you have multiple sites)? When you go to the my-provider url, is that trying to create a new one or displaying one of the above (from the screenshot)?

bs1180 commented 3 years ago

Hey, thanks for the quick response.

No, no multisite.
When I go to /my-provider it's trying to edit the IDP, not create a new one.

dsmrt commented 3 years ago

Sorry for more questions but still trying to figure this out ...

Do you have any sites configured like a default site?
Is the CP admin site domain different than the public site url?
Is your test IdP domain the same as the SP? (I'm wondering if this is it)

dsmrt commented 3 years ago

I'm not sure if this was an issue but I did change the links to be more explicit, which might help. See this change in 2.6.6. Let me know how this works for you.

bs1180 commented 3 years ago

Thanks, I think I had just misconfigured it - on a clean install it's working properly.

dsmrt commented 3 years ago

Awesome! Thanks for the update.