search

flipboxstudio / lumen-generator

A Lumen Generator You Are Missing
https://packagist.org/packages/flipbox/lumen-generator
MIT License
823 stars 126 forks source link

Flipbox\LumenGenerator\Console\ConsoleMakeCommand::handle() does not exist #18

Closed semsphy closed 7 years ago

semsphy commented 7 years ago

I got reception in latest version of Lumen (5.5.0) (Laravel Components 5.5.*).

typoworx-de commented 7 years ago

I can provide a really simple hotfix! https://github.com/typoworx-de/lumen-generator/tree/hotfix-issue-18

We just need an Abstract Class providing a shorthand to all Command-Classes and replace "extends Command" with "AbstractCommand". For a ready-patched version look at my fork.

Please approve and merge into this project.

<?php
namespace Flipbox\LumenGenerator\Console;

use Illuminate\Console\Command;

class AbstractCommand extends Command
{
    /**
     * Shorthand for Laravel 5.5.*
     * https://github.com/flipboxstudio/lumen-generator/issues/18
     *
     * @return mixed
     */
    public function handle()
    {
        $this->fire();
    }
}
Barry-Fisher commented 7 years ago

Possible duplicate with this PR? : https://github.com/flipboxstudio/lumen-generator/pull/17

joelhy commented 7 years ago

Fixed by PR #17