search

flipboxstudio / lumen-generator

A Lumen Generator You Are Missing
https://packagist.org/packages/flipbox/lumen-generator
MIT License
822 stars 126 forks source link

usage of null coalescing operator breaks PHP 5.6 support #51

Closed thomaskglas closed 5 years ago

thomaskglas commented 5 years ago

First of all, I'm not sure if this package is supposed to support PHP 5.6. If it is, support for PHP 5.6 breaks because of the use of the null coalescing operator on this line: https://github.com/flipboxstudio/lumen-generator/blob/41ec263a697e714d925252ddf305ab80e542ad21/src/LumenGenerator/Console/ControllerMakeCommand.php#L57

Was getting this error after running composer update

PHP Parse error: syntax error, unexpected '?' in /app/vendor/flipbox/lumen-generator/src/LumenGenerator/Console/ControllerMakeCommand.php on line 57

joelhy commented 5 years ago

Fixed. Please use v5.6.9

thomaskglas commented 5 years ago

Thanks @joelhy! I am having trouble installing 5.6.9, the latest version on packagist is still 5.6.8. Am I doing something wrong?

joelhy commented 5 years ago

@krisanalfa Please update packagist package.

joelhy commented 5 years ago

For now, please use develop branch by adding following code to your composer.json:

    "repositories": [
        {
            "type": "git",
            "url": "git@github.com:flipboxstudio/lumen-generator.git"
        },
    ]
    "require": {
        "flipbox/lumen-generator": "dev-develop",
        // .......   your other packages here
    },

Then run composer install