search

flipboxstudio / lumen-generator

A Lumen Generator You Are Missing
https://packagist.org/packages/flipbox/lumen-generator
MIT License
822 stars 126 forks source link

Failed to generate in Lumen 6.0.3 #60

Closed webidew closed 4 years ago

webidew commented 4 years ago

Trying to generate few models and others but failed. And after few diggin, found out the problem was in line 92 GeneratorCommand.php whichwas still calling str_replace_first().

Suggested Fix: replace it with Str::replaceFirst(). That should do the trick.

fauzipadlaw commented 4 years ago

@webidew if you know the problem, you can send PR though

webidew commented 4 years ago

Still new to git/github basically. Will try to do it later. But that was only a quickfix... Might not be the best though....

fauzipadlaw commented 4 years ago

Nah, that is okay, just send PR would be there someone else correcting it

zaherg commented 4 years ago

@webidew you need to install laravel/helpers to use the helpers.

In Laravel 6 they removed the helpers to a separate package.

ffuentese commented 4 years ago

Yep, I had the same issue. You might add laravel/helpers as a dependency for your package.

webidew commented 4 years ago

PR sent

joelhy commented 4 years ago

Merged. Please use v6.0.1