search

flipbyte / formik-json-schema

Easily create react forms using JSON / Javascript Object
MIT License
151 stars 40 forks source link

use forward ref to access the formik form #36

Closed compojoom closed 5 years ago

compojoom commented 5 years ago

This is maybe a fix for https://github.com/flipbyte/formik-json-schema/issues/35

@easeq - what do you think?

codecov-io commented 5 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   89.78%   89.81%   +0.02%     
==========================================
  Files          29       29              
  Lines         372      373       +1     
==========================================
+ Hits          334      335       +1     
  Misses         38       38
Impacted Files Coverage Δ
src/Form.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d924b4...79134af. Read the comment docs.

easeq commented 5 years ago

Have you tested it? Does it work?

compojoom commented 5 years ago

Yes, i‘m using it. I could add an example with it

easeq commented 5 years ago

That would be great! Once you've pushed the example, if everything is ok I'll merge this PR.

compojoom commented 5 years ago

Added the example. I was not sure where to place it... I created a separate exampleFormSubmitOutside container where I start the form with the basic settings and just add a submit button outside of the rendered form. Let me know if it is ok, or if you want me to modify it.

compojoom commented 5 years ago

@easeq - would you mind releasing 0.2.6 with this change? I have a teammate who is on 0.2.5 and we need this change.

easeq commented 5 years ago

I've published 0.2.6