Prevent javascript URLs warning in React 16.9

flipbyte / formik-json-schema

Easily create react forms using JSON / Javascript Object

MIT License

152 stars 40 forks source link

Prevent javascript URLs warning in React 16.9 #71

Closed andrewringler closed 4 years ago

andrewringler commented 5 years ago

Prevent javascript URLs warning in React 16.9.

React 16.9 adds the following warning:

Warning: A future version of React will block javascript: URLs as a security precaution. Use event 
handlers instead if you can. If you need to generate unsafe HTML try using 
dangerouslySetInnerHTML instead. React was passed "javascript:void(0);".

See https://github.com/facebook/react/issues/16592 for the feature issue And some related discussions here: https://github.com/facebook/react/issues/16382

andrewringler commented 5 years ago

It looks like this pull request has failing tests, but it looks like the tests starting failing at https://github.com/flipbyte/formik-json-schema/commit/fd3fb55d5585a2a86512fd78ebd879882f370467

andrewringler commented 4 years ago

Sorry those latest commits were meant for another unfinished feature branch, not this pull request. I'll edit them when i get a chance