search

flipkart-incubator / databuilderframework

A data driven execution engine
33 stars 29 forks source link

Builder whose data is not consumed in is left out of execution graph ( Because of bottom up building of graph) #17

Closed Kaustavd closed 5 years ago

Kaustavd commented 8 years ago

Builder A produces some dataA No other builder have dependency on dataA , neither in consumes, nor in optionals. Because of bottom up graph construction builder A doesn't come in in execution graph.

santanusinha commented 8 years ago

This is proper behavior. Put a dependency somewhere. Otherwise it will not get executed.

Upset the established order, and everything becomes chaos. I'm an agent of chaos. Oh and you know the thing about chaos, it's fair.

On Tue, Nov 3, 2015 at 10:13 AM, Kaustavd notifications@github.com wrote:

Builder A produces some dataA No other builder have dependency on dataA , neither in consumes, nor in optionals. Because of bottom up graph construction builder A doesn't come in in execution graph. Data A is required mostly for UI purpose.

(Use case Payment options data in checkout flow)

— Reply to this email directly or view it on GitHub https://github.com/flipkart-incubator/databuilderframework/issues/17.

Kaustavd commented 8 years ago

Is it ideal solution to provide redundant dependency between builder for stitching it together.

santanusinha commented 8 years ago

How is it logical to run unrelated builders?

There are several issues involved, when to run it being the least of it. I recommend not changing this behavior as it goes completely against the notion of data dependency.

Upset the established order, and everything becomes chaos. I'm an agent of chaos. Oh and you know the thing about chaos, it's fair.

On Tue, Nov 3, 2015 at 10:36 AM, Kaustavd notifications@github.com wrote:

Is it ideal solution to provide redundant dependency between builder for stitching it together.

— Reply to this email directly or view it on GitHub https://github.com/flipkart-incubator/databuilderframework/issues/17#issuecomment-153239681 .