search

flipkart-incubator / databuilderframework

A data driven execution engine
33 stars 29 forks source link

Making accesses mandatory for running a builder defeats purpose of statefulness of a builder #18

Closed Kaustavd closed 5 years ago

Kaustavd commented 8 years ago

Suppose any builder is stateful , which accesses same data and produces same data as action of the respective builder depends on the previous state of the data.

santanusinha commented 5 years ago

Builder is stateful? Builders are not supposed to be stateful. That is the whole reason for existence of Data. Data == State, Builder == Algorithm

Kaustavd commented 5 years ago

In case there is some use case where some data need to be updated across multiple execution and next run depends on previous state what is the suggestion? Is developer need to create another data D2 which by all means same as D1 in terms of schema. Wont it result in explosion of data?

santanusinha commented 5 years ago

This sounds like a design issue to me. Updates are not supposed to happen to the data. Once produced. In case such a flow is needed, then just the marker of such data (id of data in db or some other store), needs to be present in the Data object and updates need to happen from builder to the DB and not to the Data object.

On Wed, Aug 14, 2019 at 11:03 AM Kaustavd notifications@github.com wrote:

In case there is some use case where some data need to be updated across multiple execution and next run depends on previous state what is the suggestion? Is developer need to create another data D2 which by all means same as D1 in terms of schema. Wont it result in explosion of data?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/flipkart-incubator/databuilderframework/issues/18?email_source=notifications&email_token=AAME5Z365HFTVHIFMSUBMLTQEOKLVA5CNFSM4BTKUE6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HXQ7A#issuecomment-521107580, or mute the thread https://github.com/notifications/unsubscribe-auth/AAME5ZZ4WUYJ4W5LIDLBEJTQEOKLVANCNFSM4BTKUE6A .