search

flipkart-incubator / databuilderframework

A data driven execution engine
33 stars 29 forks source link

DataDelta content is getting changed if builder is producing the same data that is present in dataDelta. #21

Closed ToOnlyGaurav closed 5 years ago

ToOnlyGaurav commented 8 years ago

DataDelta is not cloned before passing the data to builders. If the builder produces the same data (that was present in DataDelta) after modification, it will result in changing the dataDelta content as well (as both are having the same reference).

santanusinha commented 8 years ago

It can happen if you are modifying the data instead of building it I think. Will take a look. On 26-Nov-2015 6:00 pm, "Gaurav Prasad" notifications@github.com wrote:

DataDelta is not cloned before passing the data to builders. If the builder produces the same data (that was present in DataDelta) after modification, it will result in changing the dataDelta content as well (as both are having the same reference).

— Reply to this email directly or view it on GitHub https://github.com/flipkart-incubator/databuilderframework/issues/21.

santanusinha commented 5 years ago

Need more details. Repoen with a testcase please.