search

flipkart-incubator / databuilderframework

A data driven execution engine
34 stars 29 forks source link

Accesses #3

Closed vvarma closed 6 years ago

vvarma commented 9 years ago

Changes:

  1. Add "accesses" in DataBuilderInfo and DataBuilderClassInfo
  2. DataSetAccessor .get return guava Optional
santanusinha commented 9 years ago

I recommend not merging this due to the following reasons: 1) Pull requests should do one thing. I would like it to solve only accessible. 2) Formatter run in the same pull request. 3) Optional use does not look necessary here. Will increase latency for 99% percent of the cases that will not use accessible data at all. 4) Doc not updated.

santanusinha commented 9 years ago

Are you guys planning to fix this?

vvarma commented 9 years ago

Yes we are on it, but slightly shorthanded currently. Will sync up with gokul and plan it out.

santanusinha commented 6 years ago

No movement. Closing this.