search

flipkart-incubator / databuilderframework

A data driven execution engine
34 stars 29 forks source link

Optional and Accesses #6

Closed gokulvanan closed 9 years ago

gokulvanan commented 9 years ago

Fresh pull request after merging optionals and Accesses changes.

santanusinha commented 9 years ago

Why didn't travis get triggered? Can you check once?

gokulvanan commented 9 years ago

Not sure, closing and will reopen this pull request to see if triggers travis build.

gokulvanan commented 9 years ago

reopening pull request

santanusinha commented 9 years ago

It's probably an issue with travis intg. Looking into it.

Upset the established order, and everything becomes chaos. I'm an agent of chaos. Oh and you know the thing about chaos, it's fair.

On Wed, Oct 14, 2015 at 10:53 AM, gokulvanan notifications@github.com wrote:

reopening pull request

— Reply to this email directly or view it on GitHub https://github.com/flipkart-incubator/databuilderframework/pull/6#issuecomment-147937873 .

santanusinha commented 9 years ago

Apparently they have removed adming acces to the repo for me. So I can't do squat...

Upset the established order, and everything becomes chaos. I'm an agent of chaos. Oh and you know the thing about chaos, it's fair.

On Wed, Oct 14, 2015 at 10:55 AM, Santanu Sinha santanu.sinha@gmail.com wrote:

It's probably an issue with travis intg. Looking into it.

Upset the established order, and everything becomes chaos. I'm an agent of chaos. Oh and you know the thing about chaos, it's fair.

On Wed, Oct 14, 2015 at 10:53 AM, gokulvanan notifications@github.com wrote:

reopening pull request

— Reply to this email directly or view it on GitHub https://github.com/flipkart-incubator/databuilderframework/pull/6#issuecomment-147937873 .

gokulvanan commented 9 years ago

will ask gaurav to see.. I am wondering if the issue could be because this pull is from my fork master rather than branch as in previous cases..

santanusinha commented 9 years ago

No it's probably not. The way I see it, it's not integrated in travis (the checkbox is not toggled) probably.

ToOnlyGaurav commented 9 years ago

Updated Setting. Testing Travis. (While closing and reopening)

gokulvanan commented 9 years ago

Thanks Gaurav for fixing Travis.. This one is interesting.. The test case works in Java8 with which I was running.. but breaks when I switch to Java7.. Will debug this and update here..

gokulvanan commented 9 years ago

closed till I resolve this

gokulvanan commented 9 years ago

Issue was with ordering of builders being different in Java7 and Java8. This is cause with order of Keys in Map used in building List<List> are different in both. But this is expected , the real issue is #7 which breaks in between as result this test case failed with reordered keys in java7. Currently commenting the Assertion and leaving the test to report performance numbers.