search

flipkart-incubator / phantom

Phantom is a high performance proxy for accessing distributed services. It is an RPC system with support for different transports and protocols. Phantom is inspired by Twitter Finagle clients and builds on the capabilities of technologies like Netty, Unix Domain Sockets, Netflix Hystrix and Spring. Phantom proxies have been used to serve several hundred million API calls in production deployments at Flipkart.
50 stars 27 forks source link

Overriding "getCacheKey" in HystrixTaskHandler. This enables all task #25

Closed mrphoebs closed 10 years ago

mrphoebs commented 10 years ago

handlers extending HystrixTaskHandler to implement request caching. This would also necessiate that HystrixRequestContext be initialized and shutdown for each request that triggers the task handler. I've demonstrated the usage of the above by making changes to HttpProxyExecutor and RoutingHttpChannelHandler.

regunathb commented 10 years ago

It would be better to create a sub-type to HystrixTaskHandler like RequestCachingHystrixTaskHandler and have the logic there. This would minimize regressions and implementations that require this behavior can use it. Rejecting this pull request.