search

flipkart-incubator / tef

Apache License 2.0
2 stars 2 forks source link

Exclusions are not honored, when the excluded bizlogic is added as a control dependency #16

Open vibhorgarg opened 1 month ago

vibhorgarg commented 1 month ago

Two issues

  1. When an excluded bizlogic is added as a control dependency, it is not removed from reverseBizlogicDependencyMap, and this leads to exception in the flow as CyclicDependency.
  2. The exception itself is not correct, as removing a node is not actually leading to CyclicDependency, and this misleads the developer.

Simulated the issue here -> https://github.com/flipkart-incubator/tef/pull/15

@bageshwar / @bageshwar-pn

  1. I have also updated the FlowBuilder to be JDK 17 compliant. This enables us to build tef on jdk 8 as well as jdk 17. please review that change.
vibhorgarg commented 1 month ago

@bageshwar , have pushed another commit with the fix for this bug as well. Please review.

vibhorgarg commented 1 month ago

Hi, this is the big fix -> https://github.com/flipkart-incubator/tef/pull/17/files