search

flipkart-incubator / varadhi

Apache License 2.0
25 stars 4 forks source link

Replace Component interface with Verticle. #133

Closed kmrdhruv closed 5 months ago

kmrdhruv commented 6 months ago

Closes #119

Replaces the Component interface interface with Vertx verticle.

github-actions[bot] commented 6 months ago

Test Results

213 tests   213 :white_check_mark:  37s :stopwatch:  49 suites    0 :zzz:  49 files      0 :x:

Results for commit a97b5314.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 11.44578% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 54.37%. Comparing base (78be60c) to head (08ad83f).

Files Patch % Lines
...varadhi/verticles/webserver/WebServerVerticle.java 9.55% 123 Missing :warning:
.../java/com/flipkart/varadhi/VaradhiApplication.java 0.00% 18 Missing :warning:
...radhi/verticles/controller/ControllerVerticle.java 0.00% 5 Missing :warning:
...m/flipkart/varadhi/core/cluster/ComponentKind.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #133 +/- ## ============================================ - Coverage 63.11% 54.37% -8.75% + Complexity 543 494 -49 ============================================ Files 133 130 -3 Lines 2790 2753 -37 Branches 168 167 -1 ============================================ - Hits 1761 1497 -264 - Misses 964 1201 +237 + Partials 65 55 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.