flipkart-incubator / varadhi

Apache License 2.0
26 stars 4 forks source link

FEAT: Producer side rate limiting #163

Open iosdev747 opened 2 months ago

gaurav-ashok commented 2 months ago

I think code can be placed more appropriately different modules. Have we thought, why the current current mostly is hosted in entities & server module?

I am hoping for the RL module to be independent. If not completely, then atleast core RL. Can it be done?

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 63.94984% with 115 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (78be60c) to head (03c11fc). Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
...varadhi/controller/DistributedRateLimiterImpl.java 31.42% 24 Missing :warning:
.../com/flipkart/varadhi/qos/TopicMetricsHandler.java 0.00% 21 Missing :warning:
...a/com/flipkart/varadhi/qos/RateLimiterMetrics.java 40.00% 15 Missing :warning:
...va/com/flipkart/varadhi/cluster/MessageRouter.java 10.00% 9 Missing :warning:
...in/java/com/flipkart/varadhi/utils/FutureUtil.java 0.00% 8 Missing :warning:
...varadhi/qos/weights/ExponentialWeightFunction.java 0.00% 6 Missing :warning:
.../com/flipkart/varadhi/cluster/MessageExchange.java 14.28% 6 Missing :warning:
...com/flipkart/varadhi/qos/entity/ClientHistory.java 83.33% 1 Missing and 4 partials :warning:
...rt/varadhi/qos/weights/ConstantWeightFunction.java 0.00% 4 Missing :warning:
...kart/varadhi/qos/weights/LinearWeightFunction.java 0.00% 4 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #163 +/- ## ============================================ + Coverage 63.11% 70.74% +7.62% - Complexity 543 1171 +628 ============================================ Files 133 217 +84 Lines 2790 5425 +2635 Branches 168 330 +162 ============================================ + Hits 1761 3838 +2077 - Misses 964 1430 +466 - Partials 65 157 +92 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: