I think this is bad practice because someone would be expecting to set all their configs in their deimos initializer file, but then when they try to run the app, this rake script would disable async kafka and cause some potential headaches and confusion. :P
Note though, that changing this would break backwards compatibility.
This line in the
deimos:start
task overrides theconfig.producers.backend
value.https://github.com/flipp-oss/deimos/blob/master/lib/tasks/deimos.rake#L10
I think this is bad practice because someone would be expecting to set all their configs in their deimos initializer file, but then when they try to run the app, this rake script would disable async kafka and cause some potential headaches and confusion. :P
Note though, that changing this would break backwards compatibility.