Shut down sync producers if persistent_connections is set

flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord

Other

60 stars 22 forks source link

Shut down sync producers if persistent_connections is set #11

Closed dorner closed 4 years ago

dorner commented 5 years ago

Currently Deimos shuts down async producers on app shutdown. Phobos 1.8.3 adds a persistent_connections setting so that even sync producers require shutdown. We should call that manually the same way we call async shutdown if that setting is set.

csingh commented 4 years ago

This has already been implemented: https://github.com/flipp-oss/deimos/blob/master/lib/deimos/backends/kafka.rb#L11