flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

Cpfm 246 #113

Open SeanTCasey opened 3 years ago

SeanTCasey commented 3 years ago

Description The DB Poller orders results by a timestamp (like updated_at, created_at, etc.), but if a join was done between multiple tables that share these timestamps, the order query becomes ambiguous, resulting in a crash. This fix sets the owner column for the timestamp to prevent this.

Fixes #112 (issue)

Type of change Please delete options that are not relevant.

[ X ] Bug fix (non-breaking change which fixes an issue) How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ X ] My code follows the style guidelines of this project [ X ] I have performed a self-review of my own code [ X ]I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading [ X ] My changes generate no new warnings [ X ] New and existing unit tests pass locally with my changes

dorner commented 3 years ago

@SeanTCasey looks good but: