flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

[GUILD 616] - Generator for dumping data from kafka to DB #116

Closed hemant3402 closed 3 years ago

hemant3402 commented 3 years ago

Pull Request Template

Description

1) Creates a consumer file 2) Updates the configuration to add the consumer 3) Creates a database migration to create the model 4) Creates an ActiveRecord model

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Added a generator rspec comparing the generated files to the expected output

Checklist:

dorner commented 3 years ago

@hemant3402 thanks for all the hard work with this! Unfortunately when I first created this ticket I'd completely forgotten about the existing functionality that created the table. Looking over this, the added feature of creating the consumer class and config piece are small enough (and require enough extra configuration) that I don't think it's needed.

I'm going to replace this with simply adding some text to print out after the current generator finishes suggesting how the user can do this themselves.

I'm sorry for the work that'll end up not being used, but I hope you were able to learn something while doing it!

hemant3402 commented 3 years ago

@hemant3402 thanks for all the hard work with this! Unfortunately when I first created this ticket I'd completely forgotten about the existing functionality that created the table. Looking over this, the added feature of creating the consumer class and config piece are small enough (and require enough extra configuration) that I don't think it's needed.

I'm going to replace this with simply adding some text to print out after the current generator finishes suggesting how the user can do this themselves.

I'm sorry for the work that'll end up not being used, but I hope you were able to learn something while doing it!

@dorner Yep absolutely no worries, definitely learnt a lot about rails generators and THOR CLI library while doing this