flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

GUILD-522: Add ability to generate schema model classes from schemas #122

Closed DeeChau closed 2 years ago

DeeChau commented 3 years ago

Description

New Feature - Schema Class Generation

Offer a way to generate classes from Avro schemas. These classes are documented with YARD to aid in IDE auto-complete, and will help to move errors closer to the code. These classes can be used in your application through the Consumer and Producer.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Checklist:

Suggested order of files to look at

DeeChau commented 2 years ago

Am not too sure why the rspecs are failing on CircleCI, ssh'ed into the machine and verified that the generated files are both the same (there's no noticeable diff between them)

Will review this later.

edit: Got it working, was trying to compare my_schema.rb with my_schemakey.rb ..

dorner commented 2 years ago

LGTM! Awesome job Derek, I think this is one of the biggest changes we've ever made, and definitely the biggest done by anybody other than me. :D