flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

Allow use of new avro_turf versions where child schemas are not liste… #135

Closed dorner closed 2 years ago

dorner commented 2 years ago

…d with the top level schemas

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

How Has This Been Tested?

Unit tests

Checklist:

iMacTia commented 2 years ago

Thanks both for the really quick turnaround on this 🎉 !

iMacTia commented 2 years ago

@dorner did you notice that despite the changes, tests are still not passing when executed with avro_turf ~> 1.0?

dorner commented 2 years ago

@iMacTia they have been fixed now! https://github.com/flipp-oss/deimos/pull/138

iMacTia commented 2 years ago

@dorner and it's passing on Ruby 3.0+ as well, fantastic 🎉 !