search

flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

Ci improvements #136

Closed iMacTia closed 2 years ago

iMacTia commented 2 years ago

@dorner This is still a WIP, but I'll need you're approval to run the new workflow (GitHub security check), so I'm opening the PR beforehand to let you do that 👍 This is what I'm referring to: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks.

I'll update the PR description with more details later on

iMacTia commented 2 years ago

Thank you @dorner! Did you manage to make the Action run for this branch? If not, you might need to push a first version of the CI workflow in master. Feel free to get the one from this PR (minus maybe the alternative Gemfiles, since I was still testing that out), and I'll rebase afterwards 🙌

dorner commented 2 years ago

It's running now!

iMacTia commented 2 years ago

Thanks for merging 🎉! That will help a lot with fine-tuning. Sorry if it's not going to work at first, I'll get it fixed tomorrow with another PR 🙌