Fix NameError when using Datadog Metrics

[iMacTia]

Pull Request Template

Description

Due to namespace clashing, Deimos::Metrics::Datadog is currently raising uninitialized constant Deimos::Metrics::Datadog::Statsd (NameError) when used. This can easily be fixed by adding a ::prefix to Datadog::Statsd.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The issue could be easily reproduced by using the Datadog Metrics adapter in our app. Deimos configuration:

Deimos.configure do
  metrics Deimos::Metrics::Datadog.new(...)
end

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[dorner]

LOL good catch! We actually use a vendored / namespaced version of this and we'd never used it directly. :D

[iMacTia]

Ah that explains why, I was really surprised when I saw the error 😄 !