flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

Pass Deimos logger to AvroTurf::Messaging #143

Closed iMacTia closed 2 years ago

iMacTia commented 2 years ago

Description

AvroTurf::Messaging uses a logger inside that defaults to Logger.new($stderr). This makes these logs behave differently from the other deimos logs. A custom log can be provided upon initialisation, so it makes sense to pass the configurable Deimos logger there.

Type of change

Not really sure if this qualifies as a breaking change, considering the avro_turf logs will now be sent elsewhere compared to before. But to be honest this difference in behaviour was unexpected and in my mind, this looks more like a bugfix.

How Has This Been Tested?

dorner commented 2 years ago

Thanks a bunch!