flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

New config #35

Closed dorner closed 4 years ago

dorner commented 4 years ago

Pull Request Template

Description

Fixes #18. Backwards compatibility should be completely transparent due to deprecation capability.

This introduces essentially a brand new configuration framework. We can consider breaking this out into its own gem which would be neat since it does things that (AFAICT) no other configuration gem does.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Local testing with existing Deimos app as well as new unit tests.

Checklist:

dorner commented 4 years ago

Thanks for the comments @colinmroberts! Will address this week hopefully.

dorner commented 4 years ago

@colinmroberts addressed the comments; can you give it another look?