Do not call generate_payload when payload is nil

flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord

Other

59 stars 22 forks source link

Do not call generate_payload when payload is nil #38

Closed dorner closed 4 years ago

dorner commented 4 years ago

In ActiveRecordConsumer, it will call generate_payload even when deleting a record and the payload consists of nothing but a payload_key. This should not call the method since there should be no payload to generate.

csingh commented 4 years ago

@dorner I don't see anything similar to generate_payload in ActiveRecordConsumer. Did you mean Producer? If so, is this a duplicate of #39 ?

dorner commented 4 years ago

Yep, this is a dupe. :p Destroying with extreme prejudice now.