search

flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

Crash in `produce_error` method #41

Closed dorner closed 4 years ago

dorner commented 4 years ago

In Deimos::Instrumentation, it tries accessing the metadata of the message. This is related to an old monkey patch which we've removed and always crashes:

undefined method `metadata' for #<Kafka::PendingMessage:0x0000000bb714b0>
/lib/deimos/instrumentation.rb:51:in `block in send_produce_error'

We need to rewrite this so this doesn't happen.

dorner commented 4 years ago

Duplicate of #19.