Change KafkaSource destroy callback to immediately publish instead of using send_events - Githubissues

flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord

Other

59 stars 22 forks source link

Change KafkaSource destroy callback to immediately publish instead of using send_events #42

Closed csingh closed 4 years ago

csingh commented 4 years ago

Description

Just a quick change so that KafkaSource destroy callback skips the send_event workflow, as its not required for a simple "delete" payload

Fixes #39

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Ran the RSpecs, kafka_source_spec.rb covers the case where .destroy on an ActiveRecord object should result in a nil payload published to the topic

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

csingh commented 4 years ago

@dorner added a spec!

dorner commented 4 years ago

Looks good! 👍