flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord

Other

59 stars 22 forks source link

ActiveRecord Batch Consumer #71

Closed colinmroberts closed 4 years ago

colinmroberts commented 4 years ago

Pull Request Template

Description

ActiveRecord Consumer using batch consumption

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

Added lots of new tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

colinmroberts commented 4 years ago

@dorner Made some more suggested changes

colinmroberts commented 4 years ago

@dorner Fixed the conflict 🎉

dorner commented 4 years ago

YAHOO