flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord

Other

59 stars 22 forks source link

GH-75: Handle batch of unique messages in compact_messages #85

Closed angad-singh closed 4 years ago

angad-singh commented 4 years ago

Pull Request Template

Description

compact_messages now uses uniq instead of uniq! which was causing it to fail on batch of unique messages.

Fixes #75

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] Unit tests
[x] Testing on local environment with Fadmin by monkey patching and using "Flyers.PageItem" topic (locally)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules