flipp-oss / deimos

Framework to work with Kafka, Avro and ActiveRecord
Other
59 stars 22 forks source link

GH-50: Raise error if no topic is given while producing messages #87

Closed angad-singh closed 3 years ago

angad-singh commented 3 years ago

Pull Request Template

Description

Changed the publish_list method in lib/deimos/producer.rb to raise error if the topic is blank.

Fixes #50

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

dorner commented 3 years ago

@angad-singh please fix Rubocop errors and then we're good to merge!

dorner commented 3 years ago

Woot, thanks!