search

flipper-io / flipper

Flipper is a development platform that can be controlled from any programming language.
https://www.flipper.io/
Apache License 2.0
70 stars 15 forks source link

Shake fails to process '.s' files. #67

Closed georgemorgan closed 7 years ago

georgemorgan commented 7 years ago

If a '.s' file is present in the source tree, Shake throws the following exception:

Error when running Shake build system:
* core
* osmium
* build/osmium/osmium-atsam4s16b.bin
* build/osmium/osmium-atsam4s16b.elf
* build/boards/carbon/platforms/atsam4sb/src/system/pendsv.s.arm.o
build/boards/carbon/platforms/atsam4sb/src/system/pendsv.mk: openBinaryFile: does not exist (No such file or directory)
TravisWhitaker commented 7 years ago

The only .s file in the source tree is assets/copy_sam4s.s, and that object code is manually included in the C source. If we need to add .s files then we can easily add a rule; just need to know exactly what needs to be done.

TravisWhitaker commented 7 years ago

Seems that GCC will only generate makefile fragments for .S files, and not for .s files. As long as it's not problematic for the preprocessor to run, reusing the cRule combinator for .S files probably makes the most sense.

georgemorgan commented 7 years ago

Determined was unnecessary.