flipperbw / FantasyPlus

Adds FantasyPros projections to fantasy football sites.
Mozilla Public License 2.0
88 stars 38 forks source link

Add column before ajax calls #5

Closed stabbylambda closed 10 years ago

stabbylambda commented 10 years ago

This splits up the adding of the column from the loading of the data. That way you can see that it's working before all the $.get calls come back

flipperbw commented 10 years ago

This is a good idea. I'd like to add a loading notification somewhere in there though, otherwise people might think it's broken. Trying to figure out how to do that subtley.

stabbylambda commented 10 years ago

I added a loading gif to each of the cells in the column. It's pretty small, so it's not super ugly.

flipperbw commented 10 years ago

Merged in. I had to edit a lot of things though - some of the proposed changes broke the Mutation watcher functionality and other jQuery things. Thank you for your help - this looks great.