Cleaning house, added JSON data layer

flipperbw / HSBuddy

Keep track of played cards in Hearthstone.

49 stars 9 forks source link

Cleaning house, added JSON data layer #1

Closed ghost closed 10 years ago

ghost commented 10 years ago

Cleaned up the code a little bit - moved many inline class declarations out to their own class files. Much easier to manage!

Also, I scrapped the code that was declaring DeckLists and wrote up a few classes to read that data from a JSON file.

I did this from a machine that didn't have Hearthstone installed, so I wasn't able to build and test using your TCP stack. However, I did some rudimentary testing with my changes.

Let me know if you have any questions about some of the changes I made. My main goal was to start to make parts of your code base a little easier to maintain, my second goal was to start up a super basic data access layer so you weren't declaring your datasets at run time.

Also, I opened this up in Visual Studio 2013. Apologies if that isn't the version you have installed and the sln file got converted.

flipperbw commented 10 years ago

A few issues I'm having while running:

The .csproj needs to be edited to change all mentions of Form1 to MainForm. Otherwise it doesn't load the correct files.
s_packetDecoders (MainForm, line 28) needs to be uncommented, or else we can't instantiate the decoder.
The rest of the decklists should be in the JSON file (trivial)
The first deck that shows up should be Null (should happen when the above is completed with the null decklist)
- There's an issue with the CardList class. It seems to get called every time I change decks, and tries to reread all the cards. I then get an error where the _cardList object is empty - I haven't dug into it but I think it's a scope error. This is probably the largest issue I'm having at the moment.
This is my bad, but something is weird with the PcapDotNet assemblies. If you know how to automatically just include them with the program, that would be much better I think. I always get errors about them being incompatible, in the wrong place, x86/64 MSIL, etc.

ghost commented 10 years ago

Hmm...

I know the issue with the .csproj file.. VS2013 decided to not update the project file until after the commit. Might possibly be because I didn't close VS before committing. Something to keep in mind, I s'pose.
Yup, I noticed that today as I was reading through my commit again. Whoops! I'll patch that up.
I'm not too concerned about the rest of the decklists to be honest... I'll go ahead and drop the rest of them into the JSON since I removed the decklist declarations in the first place!
I'll take a look and see what I can find in regards to the CardList class. Thanks for catching that!
Might try adding a ReferenceAssembly folder to the project, dropping the assemblies in there, then adjusting your references to look at that folder.

I've got some downtime, but I'm not at a machine with HS installed.. I'll knock down these issues and then issue another pull request. Thanks for your feedback!

flipperbw commented 10 years ago

Thanks jz. I considered adding the Hearthstone DLL's in there in case it wasn't installed/found, but ultimately decided it would make the program too bloated.