search

flipperbw / HSBuddy

Keep track of played cards in Hearthstone.
49 stars 9 forks source link

Resolved issues discovered in https://github.com/flipperbw/HSBuddy/pull/1 #2

Closed ghost closed 10 years ago

ghost commented 10 years ago

I fixed up the issues outlined in my previous pull request (here: https://github.com/flipperbw/HSBuddy/pull/1).

The comments specifically: https://github.com/flipperbw/HSBuddy/pull/1#issuecomment-44454217 https://github.com/flipperbw/HSBuddy/pull/1#issuecomment-44457053

To summarize, the .csproj file was updated to contain the new file names, several lines of necessary code that were left commented out are now no longer commented, all decklists (including the empty list) are now present in AllDeckCardLists.json, and a poorman's Singleton was implemented in CardList.cs to help with excessive instantiation (and sometimes not instantiating).

flipperbw commented 10 years ago

Awesome. I merged these in manually, as I had an enormous amount of Git headaches with conflicts. I'm closing this, but I did merge everything in your pull request. You can ask for it again if you want the credit, not sure how that works on here :)

You'll see I revamped the way the TCP capture worked - this time with threading. Take a look at some of the changes if you'd like. Not too much is different, but I ripped out all the pretty colorful stuff and updated the threading so TCP would always capture even when interrupted by the Form.

ghost commented 10 years ago

I can definitely understand merging a VS project being a headache... I have issues enough with Visual SourceSafe, which was BUILT for VS. :) I haven't the foggiest on how to "give credit" without adding as a contributor!

I definitely will take a look when I get a free moment. If you've got a wishlist of features as well, I wouldn't mind hopping in on those if you add them as issues or however you'd like to manage that.

I like what you've done so far, excited to see how much further you take it, and I'd be happy to hop on as a collaborator on this project if that's what you're looking for!

flipperbw commented 10 years ago

Yeah, I have to consolidate all the to-do's and nice-to-have's.

I've added you as a collaborator (contributor happens automatically I think). Anyway, it's already looking much cleaner. Thanks!!