Closed manewitz closed 9 months ago
The same error here on Ruby 2.7.8 and 3.1.4 via rbenv. Manually requiring irb
in the cli code in the gem does NOT solve it and moves the error to a point where IRB::Color::WHITE
is referenced.
Odd, I have Ruby 3.2.2 installed via asdf and can't duplicate. Any other info you can give me about your setup? What rails --version
? irb --version
?
❯ ruby --version
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]
~/projects/flippercloud flipper-1.2*
❯ flipper list
stats is ⏺ enabled
adapter_request_logs is ⏺ enabled
administrator is ◯ enabled for 5 actors
docsearch is ⏺ enabled
expressions is ⏺ enabled
feature_stats is ◯ enabled for 7 actors
github_auth is ⏺ enabled
github_sync is ⏺ enabled
google_auth is ⏺ enabled
helpscout is ⏺ enabled
hubspot is ⏺ enabled
plausible is ⏺ enabled
plausible_masked is ⏺ enabled
rack_mini_profiler is ◯ enabled for 1 actor
scoped_tokens is ⏺ enabled
seo is ⏺ enabled
subscriptions is ⏺ enabled
telemetry_receiving is ⏺ enabled
trail_on_create is ⏺ enabled
trial_lifecycle_emails is ⏺ enabled
version_check is ⏺ enabled
webhooks is ◯ enabled for 1 actor, 5% of actors, 2 groups
neutral_edit_feature is ⏺ enabled
userlist_onboarding is ⏺ enabled
new_marketing is ⦸ disabled
here's mine:
❯ rails --version
Rails 7.1.2
❯ irb --version
irb 1.11.1 (2024-01-08)
❯ gem --version
3.5.4
I tried commenting out my .irbrc and removing pry from my Gemfile to see if there was some issues around that but same thing.
Ok, I was finally able to duplicate this in a Rails 7.0 app. Rails 7.1 added a dependency on the irb
gem, which is where new development is happening to try to get parity with pry.
So we either need to make Flipper depend on irb
gem as well, or just make colorization optional if IRB::Color
is defined. The latter would probably be my preference.
Excited to check out the 1.2 CLI but running into this error around IRB colorization.
flipper --help
runs correctly but list, show, enable and disable are giving the same NameError. I'm on Ruby 3.2.2. via asdf. Any ideas?