flipperdevices / flipper-application-catalog

Flipper Application Catalog

621 stars 161 forks source link

Added Authenticator v5.16.1 #538

Closed akopachov closed 3 weeks ago

akopachov commented 1 month ago

Application Submission

Software-based authenticator that implements multi-factor authentication services using the time-based one-time password (TOTP; specified in RFC 6238) and HMAC-based One-time Password algorithm (HOTP; specified in RFC 4226), for authenticating users of software applications.

Extra Requirements

There is a companion app for desktop allowing you to interact with Flipper Authenticator in a more user-friendly way. The latest builds as well as all the information about it can be found in its official repo here

Author Checklist (Fill this out)

[x] I've read the contribution guidelines and my PR follows them
[x] I own the code I'm submitting or have code owner's permission to submit it
[x] I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

[x] Bundle is valid
[x] There are no obvious issues with the source code
[x] I've ran this application and verified its functionality

akopachov commented 1 month ago

From what I uderstand, fal_embedded should be set to True in manifest to let build system pack all .fal files into fap. So I did that here.

Unfortunately build fails:

fbt: warning: Failed parsing manifest 'tmpz8bo1uux\code\application.fam' : App totp cannot have fal_embedded set

if I set fal_embedded to False or remove, build passes, but from what I understand, your delivery system will not be able to deliver all the fal files alongside with fap.

hedger commented 1 month ago

From what I uderstand, fal_embedded should be set to True in manifest to let build system pack all .fal files into fap. So I did that here.

That's right. But fal_embedded is a property for plugins' manifests only, not the host application. Set it to true for every plugin and it should work.

akopachov commented 1 month ago

Ah, yeah, my bad. Fixed. Thanks

akopachov commented 1 month ago

Note for QA: it would be great if you make sure that at least totp version CLI command is working fine, to make sure that all the fal files are in place

doomwastaken commented 4 weeks ago

Greetings! Sorry for delay, I am currently on vacation and struggling with internet connection (or lack of!). I will ask one of my colleagues to test, since I have no way of downloading the app. As far as I can tell .fal did include correctly, but I did not check all plugins.

Usually we do minimal check for the .fap itself, basically that it runs and do minimal tests to it (depending on complexity, code and type of an app).

But I can tell, this is an extremely useful app and a great addition. Thank you for contribution

akopachov commented 4 weeks ago

Thanks for checking! And no worries about timings ;)

doomwastaken commented 3 weeks ago

Great work and sorry for delay!