search

flipperdevices / flipperzero-firmware

Flipper Zero firmware source code
https://flipperzero.one
GNU General Public License v3.0
12.77k stars 2.72k forks source link

[NFC] Crash when attempting to save DESFire cards #1161

Closed JackDoan closed 2 years ago

JackDoan commented 2 years ago

Describe the bug After trying to save a DESFire card, the interface hangs after submitting the file name

To Reproduce Steps to reproduce the behavior:

  1. Switch on...
  2. NFC
  3. Read Card
  4. beep when you tap a desfire card
  5. More
  6. Save
  7. enter a name
  8. enter
  9. crash

Expected behavior No crash

Logs No relevant logs. Crash seems to occur in the nfc_scene_save_name_on_event function, based on debug prints I added

Lots of these though before saving:

11594 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11599 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11605 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11610 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11615 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11621 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11626 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11632 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11637 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11643 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11649 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response
11654 [W][NfcWorker]: Bad DESFire GET_KEY_VERSION response

Target Flipper Zero

Additional context Running code from #1156 that fixes DESFire memory corruption, but doesn't seem to be related to this bug.

JackDoan commented 2 years ago

Resolved in #1156