search

flipperdevices / flipperzero-firmware

Flipper Zero firmware source code
https://flipperzero.one
GNU General Public License v3.0
12.9k stars 2.74k forks source link

Sub-GHz Read RAW function does not completely erase when tapping Erase #1252

Closed pliable closed 2 years ago

pliable commented 2 years ago

Describe the bug When using Read RAW under the Sub-GHz module, after it's done recording, tapping left will not erase the recording completely (it only seems to clear the screen). The raw recording will still appear under Saved

To Reproduce

  1. Press OK button
  2. Sub-GHz -> Read RAW
  3. Press OK button to record
  4. Press OK button to stop recording
  5. Press Left to delete
  6. (screen clears at this point)
  7. Go back one menu
  8. Select Saved
  9. Rawsignal file will be present

Expected behavior Seems like it should erase the RAW recording completely, not just clear it from the screen? At least that's what I gather it should do

Additional context It make me sad :(

Skorpionm commented 2 years ago

no, it shouldn't. when recording a RAW file, the file is immediately written to SD, since the flipper does not have enough RAM to store such large files, with a new recording, the old file will be overwritten and a new one will be written or renamed when saving. but if suddenly you pressed the wrong button, you still have a chance to save the record by renaming the temp file manually

pliable commented 2 years ago

And here I got all excited cause I thought I was helping :(. Perhaps, the wording needs to be changed to be more clear? I know I wasn't the only one who thought this was a bug.

Anyway, thank you for all your work 🙏🏼🙏🏼🙏🏼. Uh, I'll let you close it, I'll keep it open just in case lol

Skorpionm commented 2 years ago

https://github.com/flipperdevices/flipperzero-firmware/pull/1262 fix