flipperdevices / flipperzero-firmware

Flipper Zero firmware source code
https://flipperzero.one
GNU General Public License v3.0
12.56k stars 2.68k forks source link

subghz: "Add Manually" menu missing Security+ 1.0/2.0 protocols #1263

Closed digitalcircuit closed 2 years ago

digitalcircuit commented 2 years ago

Is your feature request related to a problem? Please describe. In the SubGhz app, the Add Manually menu doesn't include the option to create new/random Security+ 1.0 or 2.0 remotes.

According to what's been shared on the Flipper forums, this should not be a legal issue since it's creating a unique remote to train with your garage door opener, much like buying a new replacement remote from a store.

Describe the solution you'd like The SubGhz app gains support for creating random Security+ remotes alongside existing dynamic code generation.

Describe alternatives you've considered

Additional context Access the menu via Flipper desktop → OK button → Sub-GHzAdd Manually.

The relevant patents as mentioned in a Security+ reverse-engineering repository are either expired for Security+ 1.0 or abandoned for Security+ 2.0, so creating new/unique remotes (again, not cloning existing remotes) seems unlikely to be an issue. I am not a lawyer though.

Skorpionm commented 2 years ago

if the functionality for creating and transferring such codes is implemented, then this will not stop people at all from clanging and not legally using them

digitalcircuit commented 2 years ago

@Skorpionm Good point - I overlooked that the new randomized remote needs stored somewhere. When briefly checking the code, I also mixed up the CAME Twee protocol (static, allowed) and CAME Atomo (dynamic, not allowed).

Feel free to close this issue if desired.

While I respectfully disagree with this reasoning on a technical level, I appreciate that there's significant concern and caution around ensuring the Flipper remains legal, especially this early on (preorder stage). Not all lawyers would have the technical insight to recognize intent if misunderstandings arose, and this is assuming the Flipper team would even get a chance to defend themselves.

It might be worthwhile clarifying this within the Flipper team to help avoid confusion (as per this forum post referenced previously). I apologize for dragging this issue back up - I'll keep this in mind!

Skorpionm commented 2 years ago

https://github.com/flipperdevices/flipperzero-firmware/pull/1268 Security+ 1.0

Skorpionm commented 2 years ago

https://github.com/flipperdevices/flipperzero-firmware/pull/1273 Security+2.0